transpose kernel in vec_ops and rust binding #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Apr 8, 2024
icicle/utils/vec_ops.cu
Outdated
| * @return `cudaSuccess` if the execution was successful and an error code otherwise. | ||
| */ | ||
| extern "C" cudaError_t CONCAT_EXPAND(CURVE, TransposeBatch)( | ||
| curve_config::scalar_t* input, |
There was a problem hiding this comment.
better make the input const pointer (const scalar*). This is also true for the kernels.
In some cases (for example polynomials) the internal memory can only be accessed by const so this way means this API cannot be used.
LeonHibnik
approved these changes
Apr 8, 2024
ChickenLover
approved these changes
Apr 9, 2024
LeonHibnik
added a commit
that referenced
this pull request
Apr 9, 2024
## Describe the changes This PR adds an extern C link to the transpose kernel, now in vec_ops.cu. Also Rust binding, and I updated the test check_ntt_batch to use the new transpose function. The test passes. ## Linked Issues Resolves # --------- Co-authored-by: LeonHibnik <leon@ingonyama.com>
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
## Describe the changes This PR adds an extern C link to the transpose kernel, now in vec_ops.cu. Also Rust binding, and I updated the test check_ntt_batch to use the new transpose function. The test passes. ## Linked Issues Resolves # --------- Co-authored-by: LeonHibnik <leon@ingonyama.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds an extern C link to the transpose kernel, now in vec_ops.cu.
Also Rust binding, and I updated the test check_ntt_batch to use the new transpose function.
The test passes.
Linked Issues
Resolves #