[FEAT]: golang device slice ranges #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonHibnik
approved these changes
Apr 8, 2024
nonam3e
reviewed
Apr 8, 2024
nonam3e
approved these changes
Apr 8, 2024
ChickenLover
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Describe the changes This PR adds the capability to slice a DeviceSlice, allowing portions of data that are already on the device to be reused. Additionally, this PR removes the need for a HostSlice underlying type to implement a Size function and uses unsafe.Sizeof instead. This together with #407 will allow direct usage of gnark-crypto types with HostSlice without the need for converting to ICICLE types --------- Co-authored-by: nonam3e <timur@ingonyama.com>
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
## Describe the changes This PR adds the capability to slice a DeviceSlice, allowing portions of data that are already on the device to be reused. Additionally, this PR removes the need for a HostSlice underlying type to implement a Size function and uses unsafe.Sizeof instead. This together with #407 will allow direct usage of gnark-crypto types with HostSlice without the need for converting to ICICLE types --------- Co-authored-by: nonam3e <timur@ingonyama.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds the capability to slice a DeviceSlice, allowing portions of data that are already on the device to be reused.
Additionally, this PR removes the need for a HostSlice underlying type to implement a Size function and uses unsafe.Sizeof instead. This together with #407 will allow direct usage of gnark-crypto types with HostSlice without the need for converting to ICICLE types