Nonam3e/golang/keccak #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -245,7 +245,7 @@ namespace keccak { | |||
| CHK_IF_RETURN(cudaMallocAsync(&output_device, number_of_blocks * (D / 8), stream)); | |||
| } | |||
|
|
|||
| int number_of_threads = 1024; | |||
| int number_of_threads = 512; | |||
There was a problem hiding this comment.
Why is this being reduced?
There was a problem hiding this comment.
Keccak kernel requires a lot of registers, so running with 1024 threads won't fit the GPU
There was a problem hiding this comment.
Was this working before hand though?
ChickenLover
approved these changes
May 1, 2024
jeremyfelder
approved these changes
May 1, 2024
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
## Describe the changes This PR adds keccak bindings + passes cfg as reference in keccak cuda functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds keccak bindings + passes cfg as reference in keccak cuda functions