rust classic benches with Criterion for ecntt/msm/ntt #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhnatyk
requested review from
svpolonsky,
DmytroTym,
ChickenLover,
jeremyfelder and
LeonHibnik
There was a problem hiding this comment.
Good job with the PR @vhnatyk! We needed these benches for a long time. Left some comments that I think we should address before the merge though
ChickenLover
approved these changes
May 3, 2024
jeremyfelder
approved these changes
May 5, 2024
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
Rust idiomatic benches for EC NTT, NTT, MSM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Rust idiomatic benches for EC NTT, NTT, MSM
Linked Issues
Resolves #