fix: bug regarding polynomial evaluations view in CUDA backend #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChickenLover
reviewed
May 8, 2024
| @@ -254,7 +254,8 @@ void example_clone(const int log0) | |||
| std::cout << "h(x) = " << h(x) << " expected: " << g(x) << std::endl; | |||
| } | |||
|
|
|||
| void example_EvenOdd() { | |||
| void example_EvenOdd() | |||
There was a problem hiding this comment.
what's up with the casing here?
There was a problem hiding this comment.
fixed for the entire example
ChickenLover
approved these changes
May 8, 2024
yshekel
force-pushed
the
yshekel/poly_evals_view_bugfix
branch
from
d6b979b
to
ed26508
Compare
yshekel
force-pushed
the
yshekel/poly_evals_view_bugfix
branch
from
ed26508
to
201f6be
Compare
LeonHibnik
approved these changes
May 8, 2024
yshekel
added a commit
that referenced
this pull request
May 19, 2024
fixing: (1) not building polynomials and tests for grumpkin curve (no NTT) (2) polynomial API C++ example compilation and (when compilation is fixed) memory corruption (3) bug fix in poly CUDA backend regarding transformation to evaluations in some cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing:
(1) not building polynomials and tests for grumpkin curve (no NTT)
(2) polynomial API C++ example compilation and (when compilation is fixed) memory corruption
(3) bug fix in poly CUDA backend regarding transformation to evaluations in some cases