Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async pre-loading of all page images #9

Closed
nickian opened this issue Nov 14, 2019 · 4 comments
Closed

Async pre-loading of all page images #9

nickian opened this issue Nov 14, 2019 · 4 comments

Comments

@nickian
Copy link

nickian commented Nov 14, 2019

Loving this plugin so far. Thanks for the work.

Can this type of loading be an optional feature? I personally do not like having the image fully displayed and fuzzy while it's loading. The browser does not appear to be in a loading state while the document is loading. So if you're loading a large document that takes a long time, it can confuse people to think that they are simply looking at a bad quality mockup.

Another suggestion would maybe be a more dramatic and obvious "loading" icon than what is currently in the bottom right corner.

@MaxBazarov
Copy link
Contributor

MaxBazarov commented Nov 15, 2019

Loving this plugin so far. Thanks for the work.

Thanks for feedback!

Can this type of loading be an optional feature?

Sure. I can make it. But I'm not sure that I understand you problem correctly. Could you write a video to show how it looks for you?

@nickian
Copy link
Author

nickian commented Nov 15, 2019

Here is a screenshot example. I just exported a few random large images to show what is happening.

When first opening the page, you see this pixelated (still loading) version of the artboard. You can see it's pretty pixelated:

image1

After like 30 seconds it finishes loading and looks clear:

image2

But it's not super obvious that the image is still loading, so it's slightly confusing to see the pixelated image for a while. I think a progress bar would be the most useful with the async loading.

@MaxBazarov
Copy link
Contributor

MaxBazarov commented Nov 16, 2019 via email

@nickian
Copy link
Author

nickian commented Nov 17, 2019

Oh ok, thanks. I don't see a big difference, but maybe it's just the way the browser loads images regardless of the async.

@nickian nickian closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants