Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gulp-util #15

Merged
merged 2 commits into from Jul 19, 2018
Merged

Remove gulp-util #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfa2bc
Remove gulp-util, update dependencies.
Jul 18, 2018
5e74de1
1.3.2
Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
@@ -1,8 +1,8 @@
'use strict';
var gutil = require('gulp-util');
var through = require('through2');
var tpl = require('lodash.template');
var PluginError = gutil.PluginError;
var PluginError = require('plugin-error');
var replaceExtension = require('replace-ext');

var PLUGIN_NAME = 'gulp-template-compile';

Expand Down Expand Up @@ -33,7 +33,7 @@ module.exports = function (options) {
var namespace = getNamespaceDeclaration(options.namespace || 'JST');
var IIFE_start = options.IIFE !== false ? '(function() {\n':'';
var IIFE_end = options.IIFE !== false ? '})();':'';

var templateHeader = IIFE_start + namespace.declaration;

var NSwrapper = '\n\n' + namespace.namespace + '["'+ name.replace(/\\/g, '/') +'"] = ';
Expand Down Expand Up @@ -61,7 +61,7 @@ module.exports = function (options) {
var compiled = compiler(file);

file.contents = new Buffer(compiled);
file.path = gutil.replaceExtension(file.path, '.js');
file.path = replaceExtension(file.path, '.js');
} catch (err) {
this.emit('error', new PluginError(PLUGIN_NAME, err, {fileName: filePath}));
return callback();
Expand Down
12 changes: 7 additions & 5 deletions package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "gulp-template-compile",
"version": "1.3.1",
"version": "1.3.2",
"description": "Gulp task to precompile lodash templates",
"main": "index.js",
"author": {
Expand Down Expand Up @@ -31,11 +31,13 @@
],
"license": "MIT",
"dependencies": {
"gulp-util": "~3.0.0",
"lodash.template": "~4.2.5",
"through2": "~0.5.1"
"lodash.template": "~4.4.0",
"plugin-error": "^1.0.1",
"replace-ext": "^1.0.0",
"through2": "~0.6.1"
},
"devDependencies": {
"mocha": "*"
"mocha": "*",
"vinyl": "^2.2.0"
}
}
18 changes: 9 additions & 9 deletions test.js
View file
Open in desktop
@@ -1,6 +1,6 @@
'use strict';
var assert = require('assert');
var gutil = require('gulp-util');
var Vinyl = require('vinyl');
var tpl = require('./index');

it('should precompile lodash templates', function(cb) {
Expand All @@ -15,7 +15,7 @@ it('should precompile lodash templates', function(cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -36,7 +36,7 @@ it('should support supplying custom name in a callback', function (cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -55,7 +55,7 @@ it('should support supplying a custom namespace', function (cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -74,7 +74,7 @@ it('should support dot paths in namespace', function (cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -96,7 +96,7 @@ it('shouldn´t generate IIFE encapsulation', function(cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -118,7 +118,7 @@ it('should generate IIFE encapsulation with specific configuration', function(cb
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
Expand All @@ -137,9 +137,9 @@ it('should generate IIFE encapsulation without configuration', function(cb) {
cb();
});

stream.write(new gutil.File({
stream.write(new Vinyl({
base: __dirname,
path: __dirname + '/fixture/fixture.html',
contents: new Buffer('<h1><%= test %></h1>')
}));
});
});