Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #3

Closed
wants to merge 1 commit into from
Closed

Update __init__.py #3

wants to merge 1 commit into from

Conversation

MrSprigster
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 96.11% when pulling 737873a on MrSprigster:patch-1 into 866e469 on ingwinlu:master.

@ingwinlu
Copy link
Owner

ingwinlu commented Feb 8, 2015

already cherrypicked your commit from upstream :)

@ingwinlu ingwinlu closed this Feb 8, 2015
@MrSprigster
Copy link
Contributor Author

Cool 👍 :)

@ingwinlu
Copy link
Owner

ingwinlu commented Feb 8, 2015

the problem with that solution is that it isn't best match anymore, it just gets the best available resolution instead of the closest one to what you want

@MrSprigster
Copy link
Contributor Author

That's true but at the moment it seems to be a boolean, Twitch either provides transcoding (to all qualities) or none (just provides source).

@ingwinlu ingwinlu mentioned this pull request Feb 8, 2015
@ingwinlu
Copy link
Owner

ingwinlu commented Feb 8, 2015

don't forget about restricted streams though

@MrSprigster
Copy link
Contributor Author

Ideally (due to current lack of user auth) restricted qualities should be ignored and never reach the getQuality function.

They are defined as EXT-X-TWITCH-RESTRICTED and the lines that contained this were dropped in previous versions.

Sprig

@MrSprigster
Copy link
Contributor Author

And it looks like they still are :)

if(line.startswith('#EXT-X-MEDIA')):

@ingwinlu
Copy link
Owner

ingwinlu commented Feb 8, 2015

@MrSprigster do you mind reviewing #5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants