Append to classpath not safe without separator #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not safe to append a new path to the CLASSPATH environment variable without a path separator that is suitable for the platform. I could not think of a good/concise way to determine the appropriate path separator, but it should not be necessary to have anything remain in it, so changing from append to assignment. This resolves the "Class t16subclass not found" outstanding issue.
|
You can use https://perldoc.perl.org/Env which internally uses |
|
Or, it would work to use something like: $ENV{CLASSPATH} = join $Config{path_sep}, grep defined, $ENV{CLASSPATH}, File::Spec->catfile(qw(t t16subclass.jar));Please update to that and we can merge and make a release! |
Updated to combine with $Config{path_sep} at the suggestion of @mohawk2
|
Update done as requested. Thanks! |
|
This works a lot better if one goes ahead and loads |
mohawk2
added a commit
that referenced
this pull request
Feb 12, 2022
|
This module really needs us to bring in CI which would help everyone. @jlberner Thank you for your contribution :-) |
|
Released as 0.67! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not safe to append a new path to the CLASSPATH environment variable without a path separator that is suitable for the platform. I could not think of a good/concise way to determine the appropriate path separator, but it should not be necessary to have anything remain in it, so changing from append to assignment.
This resolves the "Class t16subclass not found" outstanding issue.