Portably handle paths so they stand a chance of working on non-Unix-like platforms #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike platforms Note that I haven't actually tested this on Win32 or platforms other than Unix-likes. I just rewrote the path handling to use File::Spec's methods.
|
@tsibley, thanks! Any chance you could add a test or 2? |
|
Probably not in the next month. I'm not sure off the top of my head how to mock up a different path handling environment, but perhaps one could specifically instantiate a Win32 File::Spec object and mock up Win32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I haven't actually tested this on Win32 or platforms other
than Unix-likes. I just rewrote the path handling to use File::Spec's
methods.