avoid {}s in generated Makefile code to avoid breaking dmake #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmake handles { and } in a special manner, which means that $(INST_ARCHLIB)
was never interpolated, but passed on as it is, which in turn broke the
cleanup phase of Inline::C.
They could be interpolated for dmake, and EUMM does that usually when
generating, but it's less of a hassle to simply avoid them in the first
place.
Fixes ingydotnet/inline-c-pm#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dmake handles { and } in a special manner, which means that
$(INST_ARCHLIB)was never interpolated, but passed on as it is, which in turn broke the cleanup phase of Inline::C.They could be interpolated for dmake, and EUMM does that usually when generating, but it's less of a hassle to simply avoid them in the first place.
Fixes ingydotnet/inline-c-pm#36