Fixes various issues with selectors not working correctly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selectors like div > div or div.class did not work for me with strawberry perl. Fetched a copy of jQuery 1.2.3 and reverse engineered the missing pieces together from there.
Conflicts: test/selectors.t
Conflicts: lib/pQuery.pm
Release resources once the main object goes out of scope. Conflicts: lib/pQuery.pm
Modern Perl seems to handle this pretty well anyway. Using the modifier is still supported and is definitely a bit faster. As long as the regexp doesn't change on run-time. http://perldoc.perl.org/perlop.html#Regexp-Quote-Like-Operators
BR tags would be written as <br></br> which is interpreted as two newlines by modern browsers.
|
Thank you for this work. I finally applied and released it. |
|
Thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectors like div > div or div.class did not work for me
with strawberry perl. Fetched a copy of jQuery 1.2.3 and
reverse engineered the missing pieces together from there.