Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reset the buffer on flush #19

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Conversation

hcarty
Copy link
Collaborator

@hcarty hcarty commented Aug 6, 2017

Otherwise the buffer contents can be overwritten after a flush.

Otherwise the buffer contents can be overwritten after a flush.
@seliopou seliopou merged commit b5eb8da into inhabitedtype:master Aug 6, 2017
@seliopou
Copy link
Member

seliopou commented Aug 6, 2017

This is a pretty bad bug. And while creating a new buffer on every flush fixes the problem, it also defeats one of the main purposes of the library, which is under normal and well-tuned operation, the library shouldn't allocate large buffers.

I'm gonna merge this so that master is correct, and open an issue to solve the allocation problem in the near future.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants