Stop to migrate and omit < 4.08 support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out that we don't need to use ppxlib to just generate AST, so I modified to use only ocaml-compiler-libs to do. |
Nymphium
changed the title
Nymphium
force-pushed
the
use-ppxlib
branch
2 times, most recently
from
92fb65c
to
f034f09
Compare
Nymphium
commented
Apr 3, 2022
src/syntax.ml
Outdated
| @@ -182,17 +182,23 @@ let module_ nm vs = Str.module_ (Mb.mk (strloc (Some nm)) (Mod.structure vs)) | |||
| (* try body with _ -> with_ *) | |||
| let try_ body with_ = Exp.try_ body [ Exp.case (Pat.any ()) with_ ] | |||
|
|
|||
| let construct lid p = | |||
| #if OCAML_VERSION >= (4, 13, 0) | |||
| let p = Option.map (fun p -> ([], p)) p in | |||
There was a problem hiding this comment.
Need to pass empty list not to use existensial type variables (<= 4.13.0).
tmcgilchrist
reviewed
Apr 3, 2022
tmcgilchrist
reviewed
Apr 3, 2022
|
Looks good @Nymphium. Could you address the 2 minor comments and ensure the commits are split into; 1 changes to the generator to add functionality (either squashing into a single commit or multiple commits if there is a good reason to) and 2 running codegen/fmt via make gen? |
9 tasks
Nymphium
force-pushed
the
use-ppxlib
branch
2 times, most recently
from
17eeba5
to
1ce2126
Compare
tmcgilchrist
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from ocaml-migrate-parsetree to ppxlib and removes version migration from the current compiler to 4.04.
All the services has an constraint
ocaml {>= "4.08"}and generating AST doesn't use new syntactic features, such as let-operator, so there was no reason to support < 4.08.