Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings issues: Default save, Refresh Recent Logs, & Bug link #22

Closed
Truncated opened this issue May 9, 2024 · 3 comments
Closed

Settings issues: Default save, Refresh Recent Logs, & Bug link #22

Truncated opened this issue May 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Truncated
Copy link

v0.1.10
Settings I've had issues with
Changing the target folder for Default Save Location gets reverted.
Steps:

  1. Change save location.
  2. Close settings
  3. Slurp Page - page is made in old location
  4. Return to settings, old value is back.

Restarting Obsidian after changing the save location works around this.


Refresh button appears to do nothing. It doesn't have any visual response to clicking or message that anything has happened, but logs also do not change. This may be working, but it would be good to show a status message or something to let me know that whatever did (or didn't) occur is expected.


Link at bottom for bug submit does nothing. I can hover and it reacts as a link, but no amount of clicking (on the link or the box-arrow icon on the right) changes this.

@inhumantsar inhumantsar added the bug Something isn't working label May 9, 2024
@inhumantsar
Copy link
Owner

inhumantsar commented May 11, 2024

i'm not able to reproduce your save location issue. could you reproduce and post your logs here? uploading the markdown file slurp creates when debug mode is on will make it easier:

  1. In settings, turn on debug mode.
  2. Close and reopen Obsidian (this is to ensure the logger restarts, only necessary if you notice that the log file wasn't created when you turned on debug mode)
  3. Slurp a page
  4. Open settings, change the save location
  5. Slurp another page (same or different, doesn't matter)
  6. Open settings, change the save location back and turn off debug mode.
  7. Drag the log file from your computer's file manager (<vault directory>/_slurplogs/slurp-<date>.md) and drop it onto the comment box for this issue.

I'm going to remove the refresh button altogether. From my testing it does work, but it's rare for the textbox to be out of date.

inhumantsar added a commit that referenced this issue May 11, 2024
- fix: refactor new note modal, add validation (#21)
- fix: remove broken github link and useless log refresh button (#22)
- fix: avoid saving settings if no changes are detected
inhumantsar added a commit that referenced this issue May 11, 2024
- fix: refactor new note modal, add validation (#21)
- fix: remove broken github link and useless log refresh button (#22)
- fix: avoid saving settings if no changes are detected
@inhumantsar
Copy link
Owner

apart from the save location issue, these should be resolved in 0.1.11

@Truncated
Copy link
Author

Save location - I've been trying to recreate it but no dice, so I'll chalk this one up to ghosts in the machine. I isolated your add-on and it works perfectly fine with 0.1.11 and the previous v. so I'm gonna call that one a unique environment issue. :)

I guess removing them is one way to do it. For future consideration, it wasn't whether it worked or not so much as it wasn't clear that it had finished whatever it was supposed to be doing and the UI doesn't give you a good feeling of a positive button push.

What I would recommend is to use the Notice option at the end of whatever command(s) your buttons are doing to let the user know it finished and didn't hit an error.

https://docs.obsidian.md/Reference/TypeScript+API/Notice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants