feat: added converting a string url to an instance of the URL #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
AndreyBelym
approved these changes
Dec 20, 2022
Aleksey28
added a commit
to DevExpress/testcafe
that referenced
this pull request
Jan 13, 2023
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose Add the possibility to run tests in ESM mode ## Approach - [X] Research ways to implement running ESM files consistently - [X] Research ways to compile test files on the run - [X] Add loader hooks for ESM - [X] Run tests with dynamic import - [x] Fix tests - [X] Add handling error `ERR_REQUIRE_ESM` - [X] Add workflow for running tests in ESM - [x] Add additional tests ## References Closes #6853 PR in `bin-v8-flags-filter` DevExpress/bin-v8-flags-filter#1 PR in `callsite-record` inikulin/callsite-record#28 Temp `bin-v8-flags-filter` assembling [bin-v8-flags-filter-1.2.0.zip](https://github.com/DevExpress/testcafe/files/10175237/bin-v8-flags-filter-1.2.0.zip) Temp `callsite-record` assembling [callsite-record-4.1.3.zip](https://github.com/DevExpress/testcafe/files/10175241/callsite-record-4.1.3.zip) ## Pre-Merge TODO - [x] Write tests for your proposed changes - [x] Make sure that existing tests do not fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run scripts with module type
filenamehas protocolfile:///.readFiledoesn't accept this format but it accepts the URL instance. In this case, it needs to transformfilenameto the URL instances.