Allow inim to be started with any -d flags #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanc-signiq
force-pushed
the
startup_symbol_defs
branch
from
6e2e05e
to
c69adb4
Compare
0atman
requested changes
Apr 5, 2020
There was a problem hiding this comment.
Please re-submit this PR with a cleaner history, looks like a really good feature - thank you @ryanc-signiq 👍
src/inim.nim
Outdated
Comment on lines
244
to
248
| let result = readLineFromStdin(getPromptSymbol(), currentExpression) | ||
| if not result: | ||
| raise newException(EOFError, "Ctrl+D was pressed") | ||
| except EOFError: | ||
| cleanExit() |
There was a problem hiding this comment.
Looks like there are some unrelated commits in this PR
src/inim.nim
Outdated
|
|
||
| var app: App | ||
|
|
||
| const | ||
| INimVersion = "0.4.1" | ||
| indentSpaces = " " | ||
| indentTriggers = [",", "=", ":", "var", "let", "const", "type", "import", | ||
| "object", "enum"] # endsWith | ||
| "object", "RootObj", "enum"] # endsWith |
Tangdongle
force-pushed
the
startup_symbol_defs
branch
from
c69adb4
to
e22f13e
Compare
|
Hey mate, I've removed the unrelated code from the commit. Apologies for the unrelated code ;) |
0atman
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
This now works to my limited understanding of the nim compiler. Without it, there's an unknown short option error, with it, it seems to be happy. Would appreciate some other test cases, but will merge for now!
Master:
λ inim -d ssl -d release
Unknown short option: "d"
Run with --help for full usage.
This PR:
λ ./inim -d ssl -d release
👑 INim 0.4.1
Nim Compiler Version 1.0.6 [Linux: amd64] at /home/oatman/.nimble/bin/nim
nim> echo "test"
test
nim>
nim> exit
λ ./inim # checking no flags still works
👑 INim 0.4.1
Nim Compiler Version 1.0.6 [Linux: amd64] at /home/oatman/.nimble/bin/nim
nim> echo "test"
test
nim> exit
0atman
added a commit
that referenced
this pull request
Apr 6, 2020
|
This is now in release 0.4.2 👌 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postional arguments at the end of the inim invocation get passed to the compiler
ie inim --nim=~/.nim/mynim -d ssl -d release