Different changes, see PR #58 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 8, 2020 10:34
This reverts commit 262e0c6.
|
This is almost the same stuff as I had in #58 but without 4->2 indent (it can be done in a separate PR). I may have introduced some new bugs but I tried to not alter the program logic (but I simplified it a bit in some places) |
Tangdongle
reviewed
Apr 14, 2020
Merged
|
This is an amazing PR, thank you so much @Yardanico! I'll get a few more PRs merged today and then cut a release 💪 Thanks @Tangdongle for the review too |
0atman
added a commit
that referenced
this pull request
Apr 14, 2020
- Massive code cleanup, also fixes 1+1 error (lol) [#60] - Added help menu [#55] - Rewrite of input functionality, using `noise`, fixes c-d [56] Many thanks to @Tangdongle and @Yardanico
|
@Yardanico I believe this is causing #63 |
|
I merged without running |
|
haha no worries; it's all about setting up automation to remove human errors; no one should have to manually run |
0atman
reviewed
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of this is described in #58 , I tried to make separate commits.
I think that after reviewing it's better to do a squash merge so that this "revert" commit doesn't get into history