Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize code #16

Merged
merged 5 commits into from
Jun 4, 2021
Merged

Reorganize code #16

merged 5 commits into from
Jun 4, 2021

Conversation

MikkelPaulson
Copy link
Collaborator

Reorganize code according to the notional structure:

  • app
    • context
    • interface
      • rich
  • parser
    • syntax
  • world
    • npc
    • region
    • location
    • demographic
  • (storage - TODO)

This is a skinny refactor at this point, with only a minimum of scaffold present to support the reorg. Broader changes to enforce the separation of concerns between top-level modules will follow in other pull requests.

For consistency with the other world components (npc and location),
moved the region module to a dedicated subdirectory. Presumably this
will be expanded in the future.
Context now falls under application logic. This requires building a
barebones scaffold to support this logic.
Move terminal module into app::interface::rich and sketch out the
surrounding structure. This will ultimately be the scaffold the rest of
the app is constructed around.
Move existing command code to parser. Will be further reorganized.
Since the actual code is derived for a macro anyway, there's no point in
maintaining these as separate modules.
@MikkelPaulson MikkelPaulson added this to In progress in Core via automation Jun 4, 2021
@MikkelPaulson MikkelPaulson merged commit 284f034 into main Jun 4, 2021
@MikkelPaulson MikkelPaulson deleted the reorganize-code branch June 4, 2021 00:02
Core automation moved this from In progress to Done Jun 4, 2021
@MikkelPaulson MikkelPaulson mentioned this pull request Jun 4, 2021
@MikkelPaulson MikkelPaulson linked an issue Jun 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Core
Done
Development

Successfully merging this pull request may close these issues.

Code refactor
1 participant