Refactor into workspace #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename module directory and clean up Cargo.toml entry.
MikkelPaulson
force-pushed
the
refactor-to-workspace
branch
from
cbd6e98
to
af847f8
Compare
Unfortunately this is a big 'un, but it's hard to rearrange this much code in bite-sized pieces. The gist of it is: * initiative::app -> initiative_core::app * initiative::world -> initiative_core::world * initiative::app::interface -> initiative_cli
Now the CLI binary starts from main.rs in the CLI package. Somehow this didn't occur to me before.
MikkelPaulson
force-pushed
the
refactor-to-workspace
branch
from
af847f8
to
9e12af9
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the project into a workspace, with all code in child crates. You may think I just (#18) refactored the entire code base, but mostly this is just continuing in the same direction as past changes.
Effectively, this leaves us with the following structure:
The web crate will follow. Generally core is currently a dumping ground for things that are used by both web and cli, but it may be further subdivided in the future.