Multi-word parsing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add alternative where CamelCase words will now be recognized as both kebab-case and space case (is that a thing?). Conversion to string still uses kebab-case always.
For the time being, all of the bespoke logic for proper nouns is just adding unnecessary complexity. Scrapped so that it can be rewritten with better context sensitivity in the future.
Update command parser to support the word parser consuming multiple words at a time. The big-O complexity suffers for it, but how long is a single input likely to be really?
MikkelPaulson
force-pushed
the
multi-word-parsing
branch
from
66d80fc
to
13d2330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements multi-word parsing of input commands. For now, this is implemented in a relatively naive way where CamelCase words derived from the word list are recognized in both hyphenated and space-separated forms.
Removes parsing logic for proper nouns. This should probably be context-sensitive (ie. don't interpret input as a proper noun unless I have that noun in my database), isn't really used yet, and could definitely be better implemented using the new multi-word parser.