Create NullDataStore #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tacked the storage backend onto app, coded with a boring ol' NullDataStore for the moment. Further changes will be required to fully parameterize the types.
There's really no distinction between the random crap dumped into Context and the stuff directly in App. We still want a child struct so that we can guard ownership a bit, but there's no reason not to consolidate the various fields of Context.
StepRng was a pain to get random-looking data from, and required the use of traits at levels where traits really weren't necessary. Switched all tests to use SmallRng with a hard-coded seed instead, matching the application logic that uses SmallRng with a random seed. (This may break in the future if SmallRng changes algorithms, but we can cross that bridge when we get to it.)
Avoid ownership issues by using a temp variable, the same way npc does.
AppMeta is becoming a catch-all container for all app metadata, removing the arbitrary Context/App separation.
The entire point of this exercise, moved data_store into AppMeta (as a dyn thingummy, natch). This will allow us to query the underlying database from the command level without adding yet another parameter to the Runnable trait.
Now initiative_core accepts a data store provided by other crates, an important step to being able to break out storage behaviour by enviroment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to rough in save/load logic, we need something to (pretend to) save/load to. The NullDataStore can do that.
This also refactors the old Context struct into a new AppMeta struct that contains literally everything the app knows, including the RNG and DataStore.