GCP length check #63
Closed
GCP length check #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shoot - I forgot that some functions (like this one) might actually append to the mutated name. I need to catch this somewhere earlier. OK, thanks for this. I don't think catching it here in the gcp file is the best place to do it, so I am going to close this PR and look into hooking the utility functions instead... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #61
This probably could do with a helper in utils.py, but this was my 'get it working' approach, not being overly familiar with the codebase.
Checking the URL before mutation doesn't solve the issue as the length blows out once the region, func_url added.
Other providers were fine, the only one I had fail (using default mutations) was this.