Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation that allows query for similar resources #5

Merged
merged 9 commits into from
May 13, 2020
Merged

Initial implementation that allows query for similar resources #5

merged 9 commits into from
May 13, 2020

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Apr 21, 2020

Current draft does following:

  • InputResource input type used by ingest(resource: InputResource!): Resource! mutation has being added an optional content: String field. If provided content will be indexed and saved in association with a resource url. Search for similar resources will query that index.
  • scanner ingest all resources along with their contents, meaning they will be indexed. (Old data in the data base will have no index). ⚠️ Running scanner while server is running might corrupt index database
  • new similar(input: String!): [Resource!]! similar(input: String!): SimilarResources! endpoint was added to the Query which can be used to query index for similar resources.~~

Screen Shot 2020-04-22 at 12 17 55 PM

@Gozala Gozala marked this pull request as draft May 13, 2020 06:10
@Gozala Gozala requested a review from pvh May 13, 2020 06:11
@Gozala Gozala assigned Gozala and unassigned pvh May 13, 2020
@Gozala Gozala marked this pull request as ready for review May 13, 2020 06:11
@Gozala
Copy link
Collaborator Author

Gozala commented May 13, 2020

@pvh I think we should land this piece. ksp-browser assumes these changes

@pvh pvh merged commit 5509c52 into inkandswitch:default May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants