-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Send facilitator requests sooner #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only get these changes to apply to Office Hours and not Deep Dives? 🙏
Done! 6be0491 I refactored While I was testing2, I caught an unexpected issue: The test Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with name change
This PR updates the logic that filters meeting issues, so that issues up to 1 week out (previously: 1 day out) are now included when determining facilitator needs.
Specifically, the
getIsTomorrow
function is renamed togetIsSoon
, and callsites in action and test code are updated accordingly.