Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send facilitator requests sooner #39

Merged
merged 5 commits into from
May 22, 2023
Merged

feat: Send facilitator requests sooner #39

merged 5 commits into from
May 22, 2023

Conversation

smockle
Copy link
Collaborator

@smockle smockle commented May 19, 2023

This PR updates the logic that filters meeting issues, so that issues up to 1 week out (previously: 1 day out) are now included when determining facilitator needs.

Specifically, the getIsTomorrow function is renamed to getIsSoon, and callsites in action and test code are updated accordingly.

@smockle smockle changed the title feat: Send meeting reminders sooner feat: Send facilitator requests sooner May 19, 2023
@smockle smockle requested a review from inkblotty May 19, 2023 17:59
Copy link
Owner

@inkblotty inkblotty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only get these changes to apply to Office Hours and not Deep Dives? 🙏

@smockle
Copy link
Collaborator Author

smockle commented May 19, 2023

Can we only get these changes to apply to Office Hours and not Deep Dives? 🙏

Done! 6be0491

I refactored getIsTomorrow and getIsSoon into a new function: getIsWithinDays. Now, Office Hours call getIsWithinDays(date, 7), and Deep Dives call getIsWithinDays(date, 1)1.

While I was testing2, I caught an unexpected issue: The test Deep Dives › getAndMapDeepDiveIssues › has expected length and first option is high priority consistently fails. I switched to main, and discovered the test is failing there too.

Footnotes

  1. It’s not an elegant function signature. I considered adding aliases, e.g. export const getIsTomorrow = (x) => getIsWithinDays(x, 1).

  2. npm ci && npm run build && npm run test

src/shared.ts Outdated Show resolved Hide resolved
Copy link
Owner

@inkblotty inkblotty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with name change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants