Return error when call was reverted

[pmikolajczyk41]

No description provided.

[deuszx]

Can you include some example? What's the context for using it? Isn't it equivalent to calling a method that returns Result<T, Err> and asserting it's Err?

[pmikolajczyk41]

@deuszx https://github.com/Cardinal-Cryptography/ink-exercises/blob/main/exercises/1-drink-test/tests/lib.rs#L61

it's not that straitghtforward - if your message returned Err(E), then the call method returns Err(<Ok(Err(E))>.encode()). And it's better to handle this here, in drink, then every time on the client side

[deuszx]

Here we're loosing information - decode_revert returns None if the underlying error is different than CallReverted. So, if it's anything else - we will fail on this expect and not provide any context for the developer to fix it.

Maybe, instead of returning Option from decode_revert, we could return a Result and on the Err side include the original error?

[pmikolajczyk41]

done