Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call runtime #40

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Call runtime #40

merged 3 commits into from
Aug 28, 2023

Conversation

pmikolajczyk41
Copy link
Member

closes #36

While the current solution is quite clean, its usage might turn out to be onerous (the vanilla way is to have a target pallet as a dependency). However, one can always prepare the object call manually without pallet (e.g. with subxt), encode it and then decode it 馃し

This problem will rise in ink! integration, where we have to implement:

fn runtime_call<'a>(
        &mut self,
        _origin: &Keypair,
        _pallet_name: &'a str,
        _call_name: &'a str,
        _call_data: Vec<Value>,
    )

where Value comes from subxt. For this however, I will try to change the API there a bit (it was designed for subxt only). Then, integration with this new code should be much easier.

Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no blockers

@pmikolajczyk41 pmikolajczyk41 merged commit 4cff120 into main Aug 28, 2023
1 check passed
@pmikolajczyk41 pmikolajczyk41 deleted the call-runtime branch August 28, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow arbitrary runtime call
2 participants