Cross-contract call tracing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
reviewed
Sep 4, 2023
|
|
||
| struct TestDebugger; | ||
| impl DebugExtT for TestDebugger { | ||
| fn after_call( |
There was a problem hiding this comment.
I'd prefer to see a test where DebugExtT::after_call is used to extract some data from the after_call trace (and before_call as well) which is then used to make some assertions in the unit test itself. I think an example like that would be far more useful for future users of this tracing feature.
There was a problem hiding this comment.
this would require interpreting Values from input_data :|
DamianStraszak
approved these changes
Sep 5, 2023
deuszx
reviewed
Sep 5, 2023
deuszx
reviewed
Sep 5, 2023
deuszx
reviewed
Sep 5, 2023
deuszx
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of the recent extension to pallet-contracts, which enables tracing cross-contract calls.