Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryException has accessability level Internal #50

Closed
nullObjectPtr opened this issue Apr 5, 2016 · 1 comment
Closed

StoryException has accessability level Internal #50

nullObjectPtr opened this issue Apr 5, 2016 · 1 comment

Comments

@nullObjectPtr
Copy link

Should be public. Can't currently catch an exception of type StoryException.

Use case: I'm writing a series of unit tests for an ink story. Would like to test that attempting to call an unbound external function throws a StoryException. Since StoryException is internal, I have to catch its parent class, Exception. But I do not want an unrelated exception to cause this test to pass when it shouldn't.

@nullObjectPtr nullObjectPtr changed the title StoryException in has accessability level Internal StoryException has accessability level Internal Apr 5, 2016
@joethephish
Copy link
Member

Thanks, good point. I've made it public in the development branch, will integrate into master in the next few days.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants