Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can Subliminal use the new -w flag to select a device using instruments? #143

Closed
MaxGabriel opened this issue Mar 23, 2014 · 10 comments · Fixed by #181
Closed

Can Subliminal use the new -w flag to select a device using instruments? #143

MaxGabriel opened this issue Mar 23, 2014 · 10 comments · Fixed by #181
Assignees
@wearhere
Labels
enhancement
Milestone
1.1

Comments

@MaxGabriel
Copy link
Contributor

I noticed in the Xcode 5.1 release notes that instruments now lets you specify a device:

The instruments command-line tool now supports specifying the simulator SDK and device type using the -w flag. To see a list of the supported simulator configurations as well as attached devices, execute instruments -s devices in a Terminal window. (14996865)

I know that Subliminal jumps through several hoops to achieve this right now—is this new feature sufficient to replace the disabling/enabling of other SDKs and such?

This isn't really an issue per se as the current approach works for me—I just wanted to let you know about this if you hadn't seen it already.
@wearhere
Copy link
Contributor

Thanks for reminding me about this! This does indeed appear to resolve http://openradar.appspot.com/radar?id=3107401 (meaning no more disabling/enabling SDKs!) as well as http://openradar.appspot.com/radar?id=3106401 (meaning we wouldn't have to override the TARGETED_DEVICE_FAMILY at build). If we could verify a work-around for http://openradar.appspot.com/14135016, we could even remove the need for subliminal-test to be run with the login password.

We should adopt this as soon as Travis picks up Xcode 5.1 (travis-ci/travis-ci#2051).

@wearhere
Copy link
Contributor

We should also investigate if maybe this new instruments can install applications on devices, which would remove our need to use the MobileDevice framework (#75).

@wearhere
Copy link
Contributor

instruments 5.1 still cannot install applications on devices, which is a bit of a shame. (But not too much, because we would want to do a clean install of the app, and I'd doubt that instruments would uninstall applications.)

@wearhere wearhere added this to the 1.1 milestone Mar 31, 2014
@wearhere
Copy link
Contributor

I'm tagging this 1.1 because it would be super nice to launch to a bunch of new people with no SDK manipulation and maybe even no login password requirement (i.e. if we can confirm pre-authorization works). Discussion on travis-ci/travis-ci#2051 seems to suggest that Travis will support 5.1 before we would be launching 1.1 anyway.

@wearhere wearhere mentioned this issue Apr 6, 2014
Closed
@wearhere
Copy link
Contributor

wearhere commented Apr 6, 2014

The README will need to be updated to reflect the requirement of Xcode 5.1 when this goes in. The README should also note that it is still possible to support iOS 5.1 using Xcode 5.1, if you run Mountain Lion and manually install the iOS 5.1 simulator.

@wearhere
Copy link
Contributor

wearhere commented Apr 6, 2014

I've got a local branch using the -w flag--just need travis-ci/travis-ci#2501 to be resolved before I can put it up.

Also, I can confirm that the old (pre-Mavericks) method of pre-authorizing instruments from travis-ci/travis-ci#1292 works. If the later technique in that thread or something similar works for Mavericks, then we can remove the need for the login password altogether!

@MaxGabriel
Copy link
Contributor Author

Nice @wearhere!

@wearhere wearhere mentioned this issue Apr 8, 2014
Open
@wearhere
Copy link
Contributor

wearhere commented Apr 8, 2014

Ok I've made the change locally to completely deprecate the --live and -login_password options. When travis-ci/travis-ci#2051 is resolved, I'll put a pull request up for this and also update the wiki to describe how instruments may be "pre-authorized" as described on travis-ci/travis-ci#1292.

@wearhere wearhere mentioned this issue Apr 8, 2014
Merged
@MaxGabriel
Copy link
Contributor Author

Travis CI is now running Mavericks

wearhere pushed a commit that referenced this issue Apr 17, 2014
Use instruments' -w flag to enforce the simulator SDK & device ty…
b50870f 
…pe. (resolves #143)

This capability, added in Xcode 5.1, obviates the need to enable/disable
SDKs to force `instruments` to use a particular SDK for testing
(http://openradar.appspot.com/radar?id=3107401) and the need to
specify the `TARGETED_DEVICE_FAMILY` argument to force `instruments`
to use a particular device family for testing
(http://openradar.appspot.com/13607967).

The first components of the configurations respected by the `-w` flag
(the device types) are the same as the items listed in the iOS Simulator's
"Hardware -> Device" menu, so `subliminal-test` remains
backwards-compatible, despite its documentation changing.

Some references to iOS 5.1 have been updated in preparation for our
eventual dropping of 5.1 support (though we still do support it currently).
@wearhere wearhere mentioned this issue Apr 17, 2014
Merged
@wearhere
Copy link
Contributor

Thanks Max! Testing now.

wearhere pushed a commit that referenced this issue Apr 17, 2014
Use instruments' -w flag to enforce the simulator SDK & device ty…
03491af 
…pe. (resolves #143)

This capability, added in Xcode 5.1, obviates the need to enable/disable
SDKs to force `instruments` to use a particular SDK for testing
(http://openradar.appspot.com/radar?id=3107401) and the need to
specify the `TARGETED_DEVICE_FAMILY` argument to force `instruments`
to use a particular device family for testing
(http://openradar.appspot.com/13607967).

The first components of the configurations respected by the `-w` flag
(the device types) are the same as the items listed in the iOS Simulator's
"Hardware -> Device" menu, so `subliminal-test` remains
backwards-compatible, despite its documentation changing.

Some references to iOS 5.1 have been updated in preparation for our
eventual dropping of 5.1 support (though we still do support it currently).
wearhere pushed a commit that referenced this issue Apr 17, 2014
Use instruments' -w flag to enforce the simulator SDK & device ty…
c03dd96 
…pe. (resolves #143)

This capability, added in Xcode 5.1, obviates the need to enable/disable
SDKs to force `instruments` to use a particular SDK for testing
(http://openradar.appspot.com/radar?id=3107401) and the need to
specify the `TARGETED_DEVICE_FAMILY` argument to force `instruments`
to use a particular device family for testing
(http://openradar.appspot.com/13607967).

The first components of the configurations respected by the `-w` flag
(the device types) are the same as the items listed in the iOS Simulator's
"Hardware -> Device" menu, so `subliminal-test` remains
backwards-compatible, despite its documentation changing.

Some references to iOS 5.1 have been updated in preparation for our
eventual dropping of 5.1 support (though we still do support it currently).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wearhere wearhere

Labels
enhancement
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Update subliminal-test to take advantage of instruments 5.1. inkling/Subliminal
2 participants
@wearhere @MaxGabriel