Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SLIsTrueWithTimeout and deprecate SLWaitUntilTrue. #241

Closed
wearhere opened this issue Jul 24, 2014 · 0 comments
Closed

Add SLIsTrueWithTimeout and deprecate SLWaitUntilTrue. #241

wearhere opened this issue Jul 24, 2014 · 0 comments
Assignees
@wearhere
Milestone
v1.2.0

Comments

@wearhere
Copy link
Contributor

To resolve confusion between SLWaitUntilTrue and SLAssertTrueWithTimeout (#236), SLWaitUntilTrue should be renamed to SLIsTrueWithTimeout. This will be done in two steps.

First, in the 1.2 timeframe, SLWaitUntilTrue should be deprecated by duplicating it as SLIsTrueWithTimeout, switching Subliminal to use it internally rather than SLWaitUntilTrue, and causing SLWaitUntilTrue to log a warning.

Then, in the 2.0 timeframe, SLWaitUntilTrue should be removed: #242.
@wearhere wearhere added this to the 1.2 milestone Jul 24, 2014
@wearhere wearhere self-assigned this Jul 24, 2014
This was referenced Jul 24, 2014
Open
Closed
aegolden added a commit that referenced this issue Aug 29, 2014
@aegolden
Merge pull request #256 from inkling/jeff/241_deprecate_SLWaitUntilTrue
b96ce92 
Deprecate `SLWaitUntilTrue` and `SLWaitUntilTrueRetryDelay`. (resolves #241)
plantpurecode pushed a commit to plantpurecode/Subliminal that referenced this issue Sep 3, 2014
Deprecate SLWaitUntilTrue and SLWaitUntilTrueRetryDelay. (resolves …
64895a5 
…inkling#241)

They have been replaced by `SLIsTrueWithTimeout` (and
`SLIsTrueRetryDelay`), to resolve confusion between `SLWaitUntilTrue` and
`SLAssertTrueWithTimeout` (inkling#236).

Use of `SLWaitUntilTrue` and `SLWaitUntilTrueRetryDelay` now causes
warnings to be logged.
plantpurecode pushed a commit to plantpurecode/Subliminal that referenced this issue Sep 3, 2014
Merge branch 'jacobrelkin+justinseanmartin/nested-uicontrols-in-table…
716478a 
…view-repro' of github.com:jacobrelkin/Subliminal into jacobrelkin+justinseanmartin/nested-uicontrols-in-tableview-repro

* 'jacobrelkin+justinseanmartin/nested-uicontrols-in-tableview-repro' of github.com:jacobrelkin/Subliminal:
  WIP
  Re-enable tappability checks within `SLPickerView`. (fixes inkling#214)
  Focused tests exclude other tests even if they cannot be run. (fixes inkling#234)
  Log an explicit warning about there not being tests to run.
  Mention that only concrete tests will be run.
  Update `+[SLTestController testsToRun:usingSeed:withFocus:]`'s docs to discuss run groups.
  Deprecate `SLWaitUntilTrue` and `SLWaitUntilTrueRetryDelay`. (resolves inkling#241)
jules2689 pushed a commit to j-mutter/Subliminal that referenced this issue Oct 16, 2014
Deprecate SLWaitUntilTrue and SLWaitUntilTrueRetryDelay. (resolves …
59e8ceb 
…inkling#241)

They have been replaced by `SLIsTrueWithTimeout` (and
`SLIsTrueRetryDelay`), to resolve confusion between `SLWaitUntilTrue` and
`SLAssertTrueWithTimeout` (inkling#236).

Use of `SLWaitUntilTrue` and `SLWaitUntilTrueRetryDelay` now causes
warnings to be logged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wearhere wearhere

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@wearhere