Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations #265

Merged
merged 68 commits into from Aug 16, 2018
Merged

New Crowdin translations #265

merged 68 commits into from Aug 16, 2018

Conversation

lexelby
Copy link
Member

@lexelby lexelby commented Aug 6, 2018

Enjoy!

@AkiraNorthstar
Copy link
Member

@kaalleen : Can you look over the last translation of mine please? For some translations I am not sure about the wording. That would be very kind of you. Tell me if you notice something.

@kaalleen
Copy link
Collaborator

@AkiraNorthstar I actually think you did a really good job, thank you for all the work! It's not easy to translate all of it with those embroidery terms.

@lexelby
Copy link
Member Author

lexelby commented Aug 16, 2018

Especially when I sometimes just make up those terms... ;)

@lexelby
Copy link
Member Author

lexelby commented Aug 16, 2018

I wish CrowdIn didn't create these gigantic pull requests. Maybe I should remove the languages from the project that don't have any translations yet. My only fear is that we don't have a good way for folks to request that we add a language so they can translate for it...

@lexelby lexelby merged commit 0483969 into master Aug 16, 2018
@lexelby lexelby deleted the l10n branch August 16, 2018 19:57
@AkiraNorthstar
Copy link
Member

Can we separate the translations from the rest?
As a submodule or as a separate repository?
So the english language file could stay with inkstitch.

Or does one of you have another idea?

@lexelby
Copy link
Member Author

lexelby commented Aug 16, 2018

Hmm, yes, I think that would be possible. The question is, would it help? We'd still have the big pull requests, just in a different repository.

I'm actually happy with having these pull requests in this repository. The problem I'm having is that it's just hard to read them, since there are pages and pages of changes in each one. Do you find it easier than I do?

@AkiraNorthstar
Copy link
Member

At the moment, each approval of the respective language is triggered by the proofreader, right? Is there a "mass approval" for you as the project manager? Or do you have to approve each language and translation individually?

@AkiraNorthstar
Copy link
Member

Or can we exclude files? https://github.com/crowdin/crowdin-cli#ignoring-directories

@lexelby
Copy link
Member Author

lexelby commented Aug 17, 2018

At the moment, each approval of the respective language is triggered by the proofreader, right?

Yes, but I have CrowdIn set to add translations to GitHub even before they're approved. My thinking is that it's quite easy to revise a translation in a later version, so why wait for approval?

But of course I'm not the main user of CrowdIn. It occurred to me that it makes more sense for you folks to manage it rather than me, so @AkiraNorthstar and @kaalleen I've set you two as Managers in the CrowdIn project. Feel free to change the settings to whatever you think is best.

Or can we exclude files? crowdin/crowdin-cli#ignoring-directories

Well, we want to translate them, right? :) I think CrowdIn only pays attention to messages.po, which is built by the Makefile.

To me, the biggest problem is that every time I change the code, the strings in messages.po move around and the line number comments change. Then CrowdIn copies those changes out to all 30 languages. The "real" changes from people adding new translations get lost among the huge number of comment and reordering changes.

I have this option set, but it doesn't seem to work:

☑ Skip untranslated strings
If checked, untranslated strings will not be included into the exported file.

@danielkschneider
Copy link
Collaborator

Hi,
Could you approve and merge the french translations in your next release (1.20) ?
No hurry, but I'd like to test these a bit and make sure that there is meaning....

  • cheers ! Daniel

@AkiraNorthstar
Copy link
Member

AkiraNorthstar commented Sep 17, 2018

Approved!
Thanks Daniel
EDIT: You are a proofreeder, so you could also approve the translation yourself ;-)

@lexelby
Copy link
Member Author

lexelby commented Sep 18, 2018

@danielkschneider Previously, we had it set up so that crowdin would create PRs like this one with new translations, but that process had a lot of deficiencies. Now, a daily cron job pulls in all newly-approved translations from CrowdIn and commits them directly to master.

However, a recent change I made broke last night's run, so I'll fix it and kick off a new one now. Sorry!

@lexelby
Copy link
Member Author

lexelby commented Sep 18, 2018

Fixed. Sorry for all the commits on master; that's the only way to test the cron job :(

@danielkschneider Now that your french translations are committed to master, I've created a branch to cause Travis to build a new development release for you. It'll show up on the releases page as soon as it's built.

@danielkschneider
Copy link
Collaborator

Hi
@AkiraNorthstar I did not understand that I have to approve and that I can (there were 2-3 pages left for approval). I do that now :)

So: the french inkstitch-test-fr_FR-linux-x86_64.tar.gz release worked fine but I will have to test a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants