-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claudine/violin and chicken scratch #2857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These look great and you can absolutely add as many letters as you wish!
…On Wed, Apr 24, 2024 at 8:24 AM Claudine Peyrat ***@***.***> wrote:
@safire3002 <https://github.com/safire3002> ,
could you please check that everything is fine with you.
Here are my changes to prepare the fonts for next inkstitch version
1. json files: for both fonts
- correct size parameter to font size in mm
- change reverse to false as there are no right to left svg file
2. violin svg file
- as maximum length of satin column was 12.8mm, add a maximum stitch
length of 8mm to all satin columns. At 120% some columns will split in two
parts but never in three
- add a rung to all columns with no rung
-simplify all underpaths
-for all satins, set underlay tolerance to 0.2, minimum stitch length
to 0.5 and minimum jump stitchh to 3mm (these are new parameters)
-there were quite a few internal jump stitches in the letters
(autosatin is not so good at avoiding that), i used jump to path to correct
than, then sometimes i swap rails as it was a better option. Now there
should be no more internal jumps, except when the letter is not connected
(like i), in that case i added a force lock stitch. And also a force lock
stitch at the end of each letter. This is to ensure that thread between
letter can be safely manually cut.
3 chicken scratch
- as maximum length of satin column is 4.5mm and max increase is 120%,
i did not add any maximum stitch length
-add the few missing trim commands
- add a rung to all columns with no rung
- -simplify all underpaths
--for all satins, set underlay tolerance to 0.2, minimum stitch length
to 0.5 and minimum jump stitch to 3mm (these are new parameters)
- there were very few internal jumps, i manually corrected that. No
more jump. I did not add any force lock stitches as there are trims command.
Would you also allow me to add all the letters that French and german
require , like é,è,ù,à,i to name a few (it is simple variation of the
letters you did, just adding a diacritic)?
------------------------------
You can view, comment on, or merge this pull request online at:
#2857
Commit Summary
- 64abb78
<64abb78>
violin serif
- 8445e89
<8445e89>
Update →.svg
- 971f21c
<971f21c>
chicken scratch
File Changes
(4 files <https://github.com/inkstitch/inkstitch/pull/2857/files>)
- *M* fonts/chicken_scratch/font.json
<https://github.com/inkstitch/inkstitch/pull/2857/files#diff-3ac723053a89bc6dbb70968d2c559a90307eecc0cef7ca962055ec86008a3815>
(4)
- *M* fonts/chicken_scratch/→.svg
<https://github.com/inkstitch/inkstitch/pull/2857/files#diff-2ad894b2fcbc5fa619e8cdc7be1ff793018fa4e1c93a064d0114be080d313b5e>
(4699)
- *M* fonts/violin_serif/font.json
<https://github.com/inkstitch/inkstitch/pull/2857/files#diff-b913d87b1f4dadde7afceed40dd05f7aee6d177f49e94267a1095629a43336e8>
(2)
- *M* fonts/violin_serif/→.svg
<https://github.com/inkstitch/inkstitch/pull/2857/files#diff-4c5ec1a3f44b412861833d9d93164c4fa05174232e48e481598699db2a4e2e40>
(12005)
Patch Links:
- https://github.com/inkstitch/inkstitch/pull/2857.patch
- https://github.com/inkstitch/inkstitch/pull/2857.diff
—
Reply to this email directly, view it on GitHub
<#2857>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAESKJRXYZ4ZWIECIBEA33DY66QBPAVCNFSM6AAAAABGW2DQACVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DCMJXGI3DKNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
add é è ê ë ÉÈË Ê
to violin serif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@safire3002 ,
could you please check that everything is fine with you?
Here are my changes to prepare the fonts for next inkstitch version
3 chicken scratch
Would you also allow me to add all the letters that French and german require , like é,è,ù,à,i to name a few (it is simple variation of the letters you did, just adding a diacritic)?