Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claudine/violin and chicken scratch #2857

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

claudinepeyrat06
Copy link
Collaborator

@claudinepeyrat06 claudinepeyrat06 commented Apr 24, 2024

@safire3002 ,
could you please check that everything is fine with you?
Here are my changes to prepare the fonts for next inkstitch version

  1. json files: for both fonts
  • correct size parameter to font size in mm
  • change reverse to false as there are no right to left svg file
  1. violin svg file
  • as maximum length of satin column was 12.8mm, add a maximum stitch length of 8mm to all satin columns. At 120% some columns will split in two parts but never in three
  • add a rung to all columns with no rung
  • simplify all underpaths
  • for all satins, set underlay tolerance to 0.2, minimum stitch length to 0.5 and minimum jump stitchh to 3mm (these are new parameters)
  • there were quite a few internal jump stitches in the letters (autosatin is not so good at avoiding that), i used jump to path to correct than, then sometimes i swap rails as it was a better option. Now there should be no more internal jumps, except when the letter is not connected (like i), in that case i added a force lock stitch. And also a force lock stitch at the end of each letter. This is to ensure that thread between letter can be safely manually cut.

3 chicken scratch

  • as maximum length of satin column is 4.5mm and max increase is 120%, i did not add any maximum stitch length
  • add the few missing trim commands
  • add a rung to all columns with no rung
  • simplify all underpaths
  • for all satins, set underlay tolerance to 0.2, minimum stitch length to 0.5 and minimum jump stitch to 3mm (these are new parameters)
  • there were very few internal jumps, i manually corrected that. No more jump. I did not add any force lock stitches as there are trim command.

Would you also allow me to add all the letters that French and german require , like é,è,ù,à,i to name a few (it is simple variation of the letters you did, just adding a diacritic)?

@safire3002
Copy link
Collaborator

safire3002 commented Apr 24, 2024 via email

@claudinepeyrat06 claudinepeyrat06 merged commit 603edb9 into main Apr 26, 2024
5 checks passed
@claudinepeyrat06 claudinepeyrat06 deleted the claudine/violin_and_chicken_scratch_ branch April 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants