Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BaseInferenceTool instead of BaseSolver for consistency #110

Closed
3 tasks done
jwhhh opened this issue Feb 6, 2023 · 0 comments · Fixed by #111
Closed
3 tasks done

Use BaseInferenceTool instead of BaseSolver for consistency #110

jwhhh opened this issue Feb 6, 2023 · 0 comments · Fixed by #111
Assignees
@jwhhh
Labels
cofi core New feature or refactoring for core api WIP Work in progress

Comments

@jwhhh
Copy link
Member

jwhhh commented Feb 6, 2023 •
edited

BaseSolver can be an alias, depending on how extensively it's used everywhere.

  • Replace BaseSolver with BaseInferenceTool in src/cofi
  • Ensure all examples still work
  • Set BaseSolver to be an alias; set cofi.solvers to be an alias of cofi.tools
@jwhhh jwhhh added the cofi core New feature or refactoring for core api label Feb 6, 2023
@jwhhh jwhhh changed the title Use BaseTool instead of BaseSolver for consistency Use BaseInferenceTool instead of BaseSolver for consistency Feb 7, 2023
@jwhhh jwhhh mentioned this issue Feb 7, 2023
Merged
@jwhhh jwhhh added the WIP Work in progress label Feb 7, 2023
@jwhhh jwhhh self-assigned this Feb 7, 2023
@jwhhh jwhhh closed this as completed in #111 Feb 8, 2023
jwhhh added a commit that referenced this issue Feb 8, 2023
@jwhhh
#111 API change: BaseSolver into BaseInferenceTool
8622861 
Close #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwhhh jwhhh

Labels
cofi core New feature or refactoring for core api WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API change: BaseSolver into BaseInferenceTool inlab-geo/cofi
1 participant
@jwhhh