Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rgl.* functions to *3d #181

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

dmurdoch
Copy link
Contributor

@dmurdoch dmurdoch commented Jan 8, 2023

Some upcoming changes to the rgl package will require changes to inlabru.
I will be deprecating a number of rgl.* function calls. You can read
about the issues here:

https://dmurdoch.github.io/rgl/articles/deprecation.html

I have made the required changes in the attached PR.

Other changes are also required to pass checks, as the code in the globe() function gives this error:

fm_sp_get_crs() was deprecated in inlabru 2.7.1 and
is now defunct.

I have not made that change.

@finnlindgren
Copy link
Collaborator

Thanks! I'd forgotten I hadn't made all the internal fixes for fm_sp_get_crs --> fm_CRS; it was meant to be only a depcrecated_warn().

@finnlindgren finnlindgren merged commit 9b0afd4 into inlabru-org:devel Jan 9, 2023
@finnlindgren finnlindgren self-assigned this Jun 20, 2023
@finnlindgren
Copy link
Collaborator

Now on CRAN due to #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants