Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the segmentation fault while logging the host on the custom HTTP logger #734

Closed
wants to merge 1 commit into from
Closed

Fix the segmentation fault while logging the host on the custom HTTP logger #734

wants to merge 1 commit into from

Conversation

serializingme
Copy link
Contributor

  • Seems to be a regression introduced in the commit
    796bfab (fix was already done in commit
    ee0b216)
  • Doesn't happen with htplib v0.5.6, but it does in the latest, v0.5.9

@serializingme
Fix the segmentation fault while logging the host on the custom HTTP …
9da5cee 
…logger.

- Seems to be a regression introduced in the commit
  796bfab (fix was already done in commit
  ee0b216)
- Doesn't happen with htplib v0.5.6, but it does in the latest, v0.5.9
@inliniac
Copy link
Contributor

prscript is happy:

I can also confirm this addresses the bug.

Will merge later. Thanks Duarte.

@serializingme
Copy link
Contributor Author

No problem :)

@inliniac inliniac mentioned this pull request Jan 10, 2014
Merged
@inliniac
Copy link
Contributor

Merged through #757

@inliniac inliniac closed this Jan 10, 2014
@serializingme serializingme deleted the dev-bug-1072 branch January 10, 2014 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serializingme @inliniac