IDumper: $databaseType is required (BC break)

inlm · Apr 25, 2018 · 06f7007 · 06f7007
1 parent c6fdf57
commit 06f7007
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Dumpers/AbstractSqlDumper.php b/src/Dumpers/AbstractSqlDumper.php
@@ -46,11 +46,11 @@ public function setHeader(array $header = NULL)
 
 
 		/**
-		 * @param  string|NULL
+		 * @param  string  see Database::*
 		 * @param  string|NULL
 		 * @return void
 		 */
-		public function start($description = NULL, $databaseType = NULL)
+		public function start($databaseType, $description = NULL)
 		{
 			if ($this->started) {
 				throw new \Inlm\SchemaGenerator\InvalidStateException('Dumper is already started.');

diff --git a/src/Dumpers/NullDumper.php b/src/Dumpers/NullDumper.php
@@ -10,11 +10,11 @@
 	class NullDumper implements IDumper
 	{
 		/**
-		 * @param  string|NULL
+		 * @param  string  see Database::*
 		 * @param  string|NULL
 		 * @return void
 		 */
-		public function start($description = NULL, $databaseType = NULL)
+		public function start($databaseType, $description = NULL)
 		{
 		}
 

diff --git a/src/IDumper.php b/src/IDumper.php
@@ -8,11 +8,11 @@
 	interface IDumper
 	{
 		/**
-		 * @param  string|NULL
+		 * @param  string  see Database::*
 		 * @param  string|NULL
 		 * @return void
 		 */
-		function start($description = NULL, $databaseType = NULL);
+		function start($databaseType, $description = NULL);
 
 
 		/**

diff --git a/src/SchemaGenerator.php b/src/SchemaGenerator.php
@@ -117,7 +117,7 @@ public function generate($description = NULL)
 			$schemaDiff = new DiffGenerator($configOld->getSchema(), $configNew->getSchema());
 
 			$this->log('Generating migrations');
-			$this->dumper->start($description, $this->databaseType);
+			$this->dumper->start($this->databaseType, $description);
 
 			foreach ($schemaDiff->getCreatedAndUpdatedTables() as $diff) {
 				if ($diff instanceof Diffs\CreatedTable) {