Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide-footer #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ichagas
Copy link

@ichagas ichagas commented Nov 1, 2016

First, thank you for this module, it is simple and useful.

I made some personal adjustments that I would love to share and make it available in the main repo.

In order to make a simpler UI interaction I added the option hide-footer which can be true or (the standard) false.

Adding this option you create 2 scenarios:

Scenario 1: With Search Bar Turned On
On this scenario:

  • The text field add and extra element (X) inside input field in the right corner for clear text (similar to a native iOS)
  • The Close/Cancel button gets room in replacement of the regular Clear button

See the example
captura de tela 2016-11-01 as 11 37 59

Scenario 2: Without Search Bar
On this scenario:

  • The Close/Cancel option is in the top right position as an X icon

See the example
captura de tela 2016-11-01 as 11 43 57

I only tested the simple selection modal, the multi must be tested but I believe it is save to say it is OK since the changes are minimal.

Regards

…sed for simple selects as well with has-search off
@bianchimro
Copy link
Member

hi @ichagas and thanks for your work!
I'm going to review your contributions ASAP, this is a nice feature indeed.

best regards
Mauro

@ichagas
Copy link
Author

ichagas commented Nov 1, 2016

Great!

I've just made some additional adjustments and perhaps inside the input field the icon ion-close-round looks better than ion-android-close that I picked earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants