Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_resource_events may leave events unhandled in case of incrmental deploy #5493

Closed
1 task
wouterdb opened this issue Feb 3, 2023 · 0 comments
Closed
1 task

get_resource_events may leave events unhandled in case of incrmental deploy #5493

wouterdb opened this issue Feb 3, 2023 · 0 comments
Assignees
@wouterdb
Labels
agent

Comments

@wouterdb
Copy link
Contributor

wouterdb commented Feb 3, 2023 •
edited by sanderr

This issue is purely theoretical and never observed.

  1. The idea of get_resource_events is Get all events that should be processed by this specific resource, for the current deployment
  2. It does this by presenting all events since the last successful deploy.
  3. However, an increment is ALSO a successful deploy, but it doesn't process events, so we might get a hole in the event processing coverage,..

I think this answer the question here:

inmanta-core/src/inmanta/server/services/resourceservice.py

Line 345 in 5e7e7c8

# does this require a different ResourceAction?

with yes

Tasks

  • implement event propagation part of the design: inmanta/designs#121
@sanderr sanderr added the agent label Feb 7, 2023
@wouterdb wouterdb self-assigned this May 2, 2023
@sanderr sanderr added discussion There is a discussion happening on this issue and removed discussion There is a discussion happening on this issue labels Jun 27, 2023
@wouterdb wouterdb mentioned this issue Aug 2, 2023
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Aug 4, 2023
@wouterdb @inmantaci
Ensure get_resource_events and resource_did_dependency_change work ac…
ea740cd 
…ross incremental compiles (Issue #5493, PR #6344)

# Description

Early review request to agree on the method used.

closes  #5493

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Aug 4, 2023
@wouterdb @inmantaci
Ensure get_resource_events and resource_did_dependency_change work ac…
5848d3e 
…ross incremental compiles (Issue #5493, PR #6344)

Pull request opened by the merge tool on behalf of #6344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterdb wouterdb

Labels
agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ability to look past incremental deploys inmanta/inmanta-core
2 participants
@wouterdb @sanderr