Log which pip index is used to install Python package #6096
Assignees
Labels
usability
This ticket is related to improved usability
Comments
inmantaci
pushed a commit
that referenced
this issue
Feb 7, 2024
…rty Python dependency if that package could not be found. (Issue #6096, PR #7132) # Description **The test is different than for iso7/master as the pipconfig did not exist yet in iso6** Add the used pip indexes to the PackageNotFound exception in run_pip closes #6096 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Feb 12, 2024
…e or third-party Python dependency if that package could not be found in the case of --no-index (Issue #6096, PR #7148) # Description [Add the used pip indexes to the PackageNotFound exception in run_pip](#7064) didn't take --no-index into account. This Pr fixes this. part of #6096 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Feb 14, 2024
…e or third-party Python dependency if that package could not be found in the case of --no-index (Issue #6096, PR #7162) # Description **Different than for iso7/master as the pipconfig did not exist in iso6** [Add the used pip indexes to the PackageNotFound exception in run_pip](#7064) didn't take --no-index into account. This Pr fixes this. part of #6096 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
env.PythonEnvironment._run_pip_install_command()method logs a message when it's not able to find a certain Python package. However, it doesn't log which indexes were used to do the installation. This issue should make sure this information is available in the log message.The text was updated successfully, but these errors were encountered: