Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude_change argument to get_resource_events #6375

Closed
wouterdb opened this issue Aug 9, 2023 · 2 comments
Closed

Add exclude_change argument to get_resource_events #6375

wouterdb opened this issue Aug 9, 2023 · 2 comments
Assignees
@FloLey

Comments

@wouterdb
Copy link
Contributor

wouterdb commented Aug 9, 2023

to be able to perform the equivalent of resource_did_dependency_change
but with details about what changed.
@sanderr
Copy link
Contributor

sanderr commented Aug 29, 2023

Is the goal here purely to send more data, or do we hope to improve performance as a result?

@wouterdb
Copy link
Contributor Author

We hope to improve performance

@FloLey FloLey self-assigned this Nov 28, 2023
@FloLey FloLey mentioned this issue Nov 28, 2023
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Nov 29, 2023
@FloLey @inmantaci
Add 'exclude_change' argument to 'get_resource_events' to be able to …
abbe52a 
…exclude some types of changes from the results. (Issue #6375, PR #6778)

# Description

Add exclude_change argument to get_resource_events to be able to perform the equivalent of resource_did_dependency_change
but with details about what changed.

closes #6375

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Nov 29, 2023
@FloLey @inmantaci
Add 'exclude_change' argument to 'get_resource_events' to be able to …
ed49b9a 
…exclude some types of changes from the results. (Issue #6375, PR #6778)

Pull request opened by the merge tool on behalf of #6778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FloLey FloLey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue6375/add_exclude_event_to_get_resource_events inmanta/inmanta-core
3 participants
@wouterdb @sanderr @FloLey