Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues with deploy/repair interval cron expressions #6549

Closed
2 tasks
sanderr opened this issue Sep 27, 2023 · 1 comment
Closed
2 tasks

fix issues with deploy/repair interval cron expressions #6549

sanderr opened this issue Sep 27, 2023 · 1 comment
Assignees
@Hugo-Inmanta

Comments

@sanderr
Copy link
Contributor

sanderr commented Sep 27, 2023

#6374 introduced the config option to use a cron expression for the repair interval. There are two things missing here:

  • there should be an environment setting for it
  • the same should be done for the deploy interval
@Hugo-Inmanta Hugo-Inmanta self-assigned this Sep 29, 2023
@Hugo-Inmanta Hugo-Inmanta mentioned this issue Oct 3, 2023
Closed
9 tasks
Hugo-Inmanta added a commit that referenced this issue Oct 6, 2023
@Hugo-Inmanta
Add support for cron expressions for autostart_agent_deploy_interval …
2d82582 
…and autostart_agent_repair_interval environment settings. (Issue #6549, PR #6574)

closes #6549

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@Hugo-Inmanta Hugo-Inmanta mentioned this issue Oct 6, 2023
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Oct 6, 2023
@Hugo-Inmanta @inmantaci
Add support for cron expressions for autostart_agent_deploy_interval …
ed21c7b 
…and autostart_agent_repair_interval environment settings. (Issue #6549, PR #6591)

Part of #6549
Follow up pr to #6574 for iso6

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@Hugo-Inmanta Hugo-Inmanta reopened this Oct 6, 2023
@Hugo-Inmanta
Copy link
Contributor

This PR is missing a migration script

@Hugo-Inmanta Hugo-Inmanta mentioned this issue Oct 9, 2023
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Oct 10, 2023
@Hugo-Inmanta @inmantaci
Add missing migration script. (Issue #6549, PR #6596)
f9789b4 
# Description

Previous PR was missing a migration script

closes #6549

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Oct 10, 2023
@Hugo-Inmanta @inmantaci
Add missing migration script. (Issue #6549, PR #6596)
25805f6 
Pull request opened by the merge tool on behalf of #6596
Hugo-Inmanta added a commit that referenced this issue Oct 10, 2023
@Hugo-Inmanta
Add support for cron expressions for autostart_agent_deploy_interval …
7003e8e 
…and autostart_agent_repair_interval environment settings. (Issue #6549, PR #6574)

closes #6549

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@Hugo-Inmanta Hugo-Inmanta mentioned this issue Oct 10, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hugo-Inmanta Hugo-Inmanta

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sanderr @Hugo-Inmanta