Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compact database migration scripts for iso<=5 #6726

Closed
5 tasks
sanderr opened this issue Nov 10, 2023 · 0 comments
Closed
5 tasks

compact database migration scripts for iso<=5 #6726

sanderr opened this issue Nov 10, 2023 · 0 comments
Assignees
@FloLey
Labels
performance Address a performance concern
Milestone
iso7

Comments

@sanderr
Copy link
Contributor

sanderr commented Nov 10, 2023 •
edited

Migration scripts can take a long time to execute. We can improve this by getting rid of the older ones, for versions the noone is running anymore. Concretely, we would apply all scripts earlier than the first iso6 release, then dump the schema in v1.py.

Only for iso7

  • apply for core
  • apply for inmanta-lsm
  • add change entry for both, warning that to upgrade to this version you have to be running at least version <latest_component_version_in_iso5>
  • document procedure in internal docs, including which branches to merge it in and which scripts to include
  • after merging, notify solutions and frontend teams
@sanderr sanderr added discussion There is a discussion happening on this issue performance Address a performance concern and removed discussion There is a discussion happening on this issue labels Nov 10, 2023
@sanderr sanderr added this to the iso7 milestone Nov 28, 2023
@FloLey FloLey self-assigned this Nov 28, 2023
@FloLey FloLey mentioned this issue Dec 1, 2023
Closed
13 tasks
inmantaci pushed a commit that referenced this issue Dec 6, 2023
@FloLey @inmantaci
fix issue outputfile compact script (Issue #6726, PR #6829)
7058f64 
# Description

while testing the script on inmanta-lsm I noticed the output location was wrong.
This will fix it.

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@FloLey FloLey reopened this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FloLey FloLey

Labels
performance Address a performance concern
Projects
None yet
Milestone
iso7
Development

Successfully merging a pull request may close this issue.

Issue/6726 compact database migration scripts inmanta/inmanta-core
2 participants
@sanderr @FloLey