Don't purge latest released version #7324
Assignees
Labels
bug
Something isn't working
Comments
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Mar 22, 2024
…ould be removed by the cleanup job. (Issue #7324, PR #7412) # Description Fix bug where the latest released version of the configurationmodel could be removed by the cleanup job. closes #7324 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
arnaudsjs
added a commit
that referenced
this issue
Mar 22, 2024
…ould be removed by the cleanup job. (Issue #7324, PR #7412) Fix bug where the latest released version of the configurationmodel could be removed by the cleanup job. closes #7324 - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Mar 22, 2024
…ould be removed by the cleanup job. (Issue #7324, PR #7426) # Description **Same PR as #7412 but applied on the iso6 branch due to a merge conflict** Fix bug where the latest released version of the configurationmodel could be removed by the cleanup job. closes #7324 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
OrchestrationService._purge_versions()method ensures that we only keep X configuration model versions, where X is determined by the value of theavailable_versions_to_keepenvironment setting. However, this method doesn't take into account that it should never remove the latest released version.The text was updated successfully, but these errors were encountered: