Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale code in agent's code directory for std module #7388

Closed
2 tasks done
edvgui opened this issue Mar 19, 2024 · 0 comments
Closed
2 tasks done

Stale code in agent's code directory for std module #7388

edvgui opened this issue Mar 19, 2024 · 0 comments
Assignees
@wouterdb
Labels
bug Something isn't working
Milestone
iso7.1

Comments

@edvgui
Copy link
Contributor

edvgui commented Mar 19, 2024 •
edited by wouterdb

Action

  • drop the warning: it's too trigger-happy and we can't easily make it more accurate
  • mitigate the issue by clearing the agent code dir when the agent starts. This ensures that when a user restarts an agent, we start clean. It's not perfect, but acceptable considering that the issue will no longer be relevant with the iso8 agent rework.

Motivation

All the development orchestrators now show this warning notification:
image

  1. This is a bug: incremental deploys only deploy code for the resources in the increment. This makes the warning fire regularly for incremental deploys, while the scenario we're trying to detect has not occurred.
  2. This is very spammy (why is it triggered 23 times here?)
@edvgui edvgui added the bug Something isn't working label Mar 19, 2024
@sanderr sanderr added this to the iso7.1 milestone Mar 19, 2024
@wouterdb wouterdb self-assigned this Mar 19, 2024
@wouterdb wouterdb mentioned this issue Mar 19, 2024
Closed
9 tasks
@wouterdb wouterdb mentioned this issue Mar 22, 2024
Closed
wouterdb added a commit that referenced this issue Mar 22, 2024
@wouterdb
Remove stale code warning (Issue #7388, PR #7396)
3001d7a 
Cleanup code folder on agent restart

closes  #7388

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [X] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Mar 22, 2024
@wouterdb @inmantaci
Remove stale code warning (Issue #7388, PR #7424)
4d43728 
# Description

Stage 2 for #7396
Fixes #7388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterdb wouterdb

Labels
bug Something isn't working
Projects
None yet
Milestone
iso7.1
Development

Successfully merging a pull request may close this issue.

Cleanup code folder on agent restart inmanta/inmanta-core
3 participants
@wouterdb @sanderr @edvgui