Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put_partial causes release_version to fail if undefined resources are removed from the resource set #7416

Closed
2 tasks done
wouterdb opened this issue Mar 21, 2024 · 0 comments
Closed
2 tasks done

put_partial causes release_version to fail if undefined resources are removed from the resource set #7416

wouterdb opened this issue Mar 21, 2024 · 0 comments
Assignees
@arnaudsjs
Labels
bug Something isn't working
Milestone
iso7.1

Comments

@wouterdb
Copy link
Contributor

wouterdb commented Mar 21, 2024 •
edited by arnaudsjs

  1. when a resource is removed from a resource set, it is not removed from the 'undeployable' resource field on the model
  2. this causes release_version to fail when it calls resource_action_update
  3. this failure condition is not checked and silently ignored

Todo

  • make resource_action_update raise exceptions when it fails
  • fix the underlying issue
@sanderr sanderr added the bug Something isn't working label Mar 21, 2024
@sanderr sanderr added this to the iso7.1 milestone Mar 21, 2024
@arnaudsjs arnaudsjs self-assigned this Mar 22, 2024
@arnaudsjs arnaudsjs mentioned this issue Mar 22, 2024
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Mar 25, 2024
@arnaudsjs @inmantaci
Fix bug where undefined and skipped_for_undefined resources are not c…
0002f38 
…orrectly merged by the put_partial endpoint. (Issue #7416, PR #7429)

# Description

Fix bug where `undefined` and `skipped_for_undefined` resources are not correctly merged by the put_partial endpoint.

closes #7416

# Self Check:

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
inmantaci pushed a commit that referenced this issue Mar 25, 2024
@arnaudsjs @inmantaci
Fix bug where undefined and skipped_for_undefined resources are not c…
e9ce32d 
…orrectly merged by the put_partial endpoint. (Issue #7416, PR #7429)

Pull request opened by the merge tool on behalf of #7429
arnaudsjs added a commit that referenced this issue Mar 25, 2024
@arnaudsjs
Fix bug where undefined and skipped_for_undefined resources are not c…
e6e3022 
…orrectly merged by the put_partial endpoint. (Issue #7416, PR #7429)

Fix bug where `undefined` and `skipped_for_undefined` resources are not correctly merged by the put_partial endpoint.

closes #7416

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
@arnaudsjs arnaudsjs mentioned this issue Mar 25, 2024
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Mar 26, 2024
@arnaudsjs @inmantaci
Fix bug where undefined and skipped_for_undefined resources are not c…
7c9a32c 
…orrectly merged by the put_partial endpoint. (Issue #7416, PR #7432)

# Description

**Same PR as #7429 but applied on the iso6 branch due to a merge conflict.**

Fix bug where `undefined` and `skipped_for_undefined` resources are not correctly merged by the put_partial endpoint.

closes #7416

# Self Check:

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaudsjs arnaudsjs

Labels
bug Something isn't working
Projects
None yet
Milestone
iso7.1
Development

Successfully merging a pull request may close this issue.

Fix incorrect merging of undefined resources by put_partial inmanta/inmanta-core
3 participants
@wouterdb @arnaudsjs @sanderr