Improve support four-digit version on 'inmanta module release' command #7521
Assignees
Comments
arnaudsjs
added
support
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Apr 24, 2024
…mmand. If the 'use_four_digit' is set to 'True' in the module's metadata, the version will be bumped to a 4 digit format after a release. (Issue #7521, PR #7527) # Description The inmanta module release command performs a patch-level version bump right after applying the git tag. But some modules use four-digit version numbers in general. This ticket should make sure that the inmanta module release command has support to bump to a four digit version number after a release. Make this configurable in the module metadata file (setup.cfg -> inmanta.module.ModuleV2Metadata) closes #7521 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci
pushed a commit
that referenced
this issue
Apr 24, 2024
…mmand. If the 'use_four_digit' is set to 'True' in the module's metadata, the version will be bumped to a 4 digit format after a release. (Issue #7521, PR #7527) # Description The inmanta module release command performs a patch-level version bump right after applying the git tag. But some modules use four-digit version numbers in general. This ticket should make sure that the inmanta module release command has support to bump to a four digit version number after a release. Make this configurable in the module metadata file (setup.cfg -> inmanta.module.ModuleV2Metadata) closes #7521 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
inmanta module releasecommand performs a patch-level version bump right after applying the git tag. But some modules use four-digit version numbers in general. This ticket should make sure that theinmanta module releasecommand has support to bump to a four digit version number after a release.Proposal: Make this configurable in the module metadata file (
setup.cfg->inmanta.module.ModuleV2Metadata)The text was updated successfully, but these errors were encountered: