dropped dependency on requests[chardet] #4467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugo-Inmanta
approved these changes
Jun 28, 2022
arnaudsjs
approved these changes
Jun 28, 2022
sanderr
commented
Jun 28, 2022
arnaudsjs
requested changes
Jun 28, 2022
arnaudsjs
approved these changes
Jun 28, 2022
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Jun 28, 2022
…n restored (PR #4467) # Description With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree? # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
|
Failed to merge changes into iso4 due to merge conflict.Please open a pull request for these branches separately. |
|
Merged into branches master in e34829f |
inmantaci
pushed a commit
that referenced
this pull request
Jun 28, 2022
…n restored (PR #4467) # Description With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree? # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
|
Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches. You can safely close this pull request and delete the source branch. |
|
This branch was not deleted as it seems to still be in use. |
|
Processing #4472. |
|
Merged in iso4 in 03997ce |
arnaudsjs
pushed a commit
that referenced
this pull request
Jul 28, 2022
…n restored (PR #4467) With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree? Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
arnaudsjs
pushed a commit
that referenced
this pull request
Jul 28, 2022
…n restored (PR #4467) With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree? Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
arnaudsjs
pushed a commit
that referenced
this pull request
Jul 28, 2022
…n restored (PR #4467) With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree? Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree?
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the boxReviewer Checklist: