Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/6025 implement discovery handler #6264

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
b55d152
[WIP]
Hugo-Inmanta Jul 7, 2023
cad6ced
[FIX] fix broken anchor in link
Hugo-Inmanta Jul 7, 2023
31dec93
[WIP]
Hugo-Inmanta Jul 7, 2023
8dba6f1
[WIP] Implement top-level handler ABC
Hugo-Inmanta Jul 10, 2023
769ab33
[FIX] remove unrelated change
Hugo-Inmanta Jul 10, 2023
5a6919f
[WIP]
Hugo-Inmanta Jul 10, 2023
15856ba
[WIP]
Hugo-Inmanta Jul 11, 2023
61a75cb
[FIX]
Hugo-Inmanta Jul 12, 2023
1b0b7c9
Merge branch 'issue/6025-implement-top-level-handler-ABC' into issue/…
Hugo-Inmanta Jul 12, 2023
cfc0ce3
[DOC] add documentation for Id and resource_str
Hugo-Inmanta Jul 12, 2023
9e010ca
[WIP]
Hugo-Inmanta Jul 12, 2023
247b5e9
[WIP]
Hugo-Inmanta Jul 12, 2023
7f02a3c
[WIP]
Hugo-Inmanta Jul 13, 2023
1357fef
[WIP]
Hugo-Inmanta Jul 13, 2023
69f5439
Merge branch 'master' into issue/6025-implement-discovery-handler
Hugo-Inmanta Jul 13, 2023
6996342
[WIP]
Hugo-Inmanta Jul 13, 2023
9b75118
[WIP]
Hugo-Inmanta Jul 13, 2023
8f0092d
[WIP]
Hugo-Inmanta Jul 13, 2023
1f010bb
[GIT] move documentation to a separate PR
Hugo-Inmanta Jul 13, 2023
af7fbdd
[FORMAT]
Hugo-Inmanta Jul 17, 2023
4549578
[FIX] PEP8
Hugo-Inmanta Jul 17, 2023
5bcc5e4
Update src/inmanta/agent/handler.py
Hugo-Inmanta Jul 19, 2023
9819c83
[FIX] fix typo
Hugo-Inmanta Jul 17, 2023
466dfda
[WIP]
Hugo-Inmanta Jul 19, 2023
e6c65cd
[WIP]
Hugo-Inmanta Jul 19, 2023
982db23
Merge branch 'master' into issue/6025-implement-top-level-handler-ABC
Hugo-Inmanta Jul 19, 2023
d1b54b0
[FORMAT]
Hugo-Inmanta Jul 19, 2023
c6d5a69
[DOC] add changelog
Hugo-Inmanta Jul 19, 2023
172fc07
Merge branch 'issue/6025-implement-top-level-handler-ABC' into issue/…
Hugo-Inmanta Jul 19, 2023
be3ea06
[FORMAT] comply to black/pep8
Hugo-Inmanta Jul 19, 2023
1a70961
[WIP]
Hugo-Inmanta Jul 19, 2023
c4274b8
[WIP]
Hugo-Inmanta Jul 19, 2023
62f9d3c
[FORMAT]
Hugo-Inmanta Jul 19, 2023
d7c7996
[WIP]
Hugo-Inmanta Jul 19, 2023
b1dcdf9
[WIP]
Hugo-Inmanta Jul 19, 2023
3a22bc6
[WIP]
Hugo-Inmanta Jul 19, 2023
2b67264
[WIP]
Hugo-Inmanta Jul 21, 2023
b80dafa
[WIP]
Hugo-Inmanta Jul 21, 2023
3fd115d
Merge branch 'master' into issue/6025-implement-discovery-handler
Hugo-Inmanta Jul 21, 2023
66d5008
Update src/inmanta/agent/handler.py
Hugo-Inmanta Jul 21, 2023
ce2330a
[WIP]
Hugo-Inmanta Jul 21, 2023
5312f01
Merge remote-tracking branch 'refs/remotes/origin/issue/6025-implemen…
Hugo-Inmanta Jul 21, 2023
a14cdfd
[WIP]
Hugo-Inmanta Jul 21, 2023
cd84b14
[WIP]
Hugo-Inmanta Jul 21, 2023
4db9db7
[WIP]
Hugo-Inmanta Jul 21, 2023
705024c
[FORMAT] comply to black/pep8
Hugo-Inmanta Jul 24, 2023
806acd1
[DOC]
Hugo-Inmanta Jul 24, 2023
01023e6
[WIP]
Hugo-Inmanta Jul 24, 2023
5c62a8a
Merge branch 'issue/6025-implement-top-level-handler-ABC' into issue/…
Hugo-Inmanta Jul 24, 2023
e863677
Merge branch 'master' into issue/6025-implement-discovery-handler
Hugo-Inmanta Jul 25, 2023
cf516ae
[WIP]
Hugo-Inmanta Jul 25, 2023
ed99bd0
[WIP]
Hugo-Inmanta Jul 25, 2023
3357e12
[WIP]
Hugo-Inmanta Jul 25, 2023
8e894c2
[WIP]
Hugo-Inmanta Jul 25, 2023
8127220
[WIP]
Hugo-Inmanta Jul 25, 2023
806e730
proposal for handler api class
wouterdb Jul 31, 2023
2f3555b
Merge branch 'issue/handler_abc_wdb' into issue/6025-implement-top-le…
Hugo-Inmanta Aug 1, 2023
f3473eb
[WIP]
Hugo-Inmanta Aug 1, 2023
d99ceee
Merge branch 'issue/6025-implement-top-level-handler-ABC' into issue/…
Hugo-Inmanta Aug 1, 2023
72a61bb
[WIP]
Hugo-Inmanta Aug 1, 2023
4c97da5
Update src/inmanta/agent/handler.py
Hugo-Inmanta Aug 2, 2023
90f7509
Merge branch 'issue/6025-implement-top-level-handler-ABC' into issue/…
Hugo-Inmanta Aug 2, 2023
221a0f0
[WIP]
Hugo-Inmanta Aug 2, 2023
f1f37ed
[WIP]
Hugo-Inmanta Aug 2, 2023
1fa818d
Merge branch 'master' into issue/6025-implement-discovery-handler
Hugo-Inmanta Aug 2, 2023
be04e9a
[WIP]
Hugo-Inmanta Aug 2, 2023
334fb7f
Merge branch 'master' into issue/6025-implement-discovery-handler
Hugo-Inmanta Aug 2, 2023
ebb3580
[FIX] fix bound type
Hugo-Inmanta Aug 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/unreleased/6025-implement-discovery-handler.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
description: Add DiscoveryHandler interface to discover unmanaged resources.
issue-nr: 6025
change-type: minor
destination-branches: [master, iso6]
sections:
feature: "{{description}}"
2 changes: 1 addition & 1 deletion docs/glossary.rst
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Glossary
server.

infrastructure
That what Inmanta manages. This could be virtual machines with resources in these virtual
This is what Inmanta manages. This could be virtual machines with resources in these virtual
machines. Physical servers and their os. Containers or resources at a cloud provider without
any servers (e.g. "serverless")

Expand Down
6 changes: 3 additions & 3 deletions src/inmanta/agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from inmanta.agent import config as cfg
from inmanta.agent import handler
from inmanta.agent.cache import AgentCache
from inmanta.agent.handler import ResourceHandler, SkipResource
from inmanta.agent.handler import HandlerAPI, SkipResource
from inmanta.agent.io.remote import ChannelClosedException
from inmanta.agent.reporting import collect_report
from inmanta.const import ParameterSource, ResourceState
Expand Down Expand Up @@ -151,7 +151,7 @@ async def _execute(self, ctx: handler.HandlerContext, requires: Dict[ResourceIdS
ctx.debug("Start deploy %(deploy_id)s of resource %(resource_id)s", deploy_id=self.gid, resource_id=self.resource_id)

# setup provider
provider: Optional[ResourceHandler] = None
provider: Optional[HandlerAPI] = None
try:
provider = await self.scheduler.agent.get_provider(self.resource)
except ChannelClosedException as e:
Expand Down Expand Up @@ -766,7 +766,7 @@ def _can_get_resources(self) -> bool:
return False
return True

async def get_provider(self, resource: Resource) -> ResourceHandler:
async def get_provider(self, resource: Resource) -> HandlerAPI:
provider = await asyncio.get_running_loop().run_in_executor(
self.provider_thread_pool, handler.Commander.get_provider, self._cache, self, resource
)
Expand Down