number type should no longer differentiate between integer and decima… #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l notation when used in indexes. (Issue #6526, PR #6772) # Description 1. create the float type which is like a float in python. Update documentation to mention number will be deprecated 2. add testcases for following scenario and fix it ``` entity A: float x end implement A using std::none index A(x) std::print(A(x=0) == A(x=0.0)) ``` This will still not work with the number type 3. index lookup on float with int should work closes #6526 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
sanderr
approved these changes
Dec 4, 2023
|
Processing this pull request |
|
Merged into branches iso6 in 26d8f2e |
inmantaci
pushed a commit
that referenced
this pull request
Dec 4, 2023
…l notation when used in indexes. (Issue #6526, PR #6800) …l notation when used in indexes. (Issue #6526, PR #6772) # Description 1. create the float type which is like a float in python. Update documentation to mention number will be deprecated 2. add testcases for following scenario and fix it ``` entity A: float x end implement A using std::none index A(x) std::print(A(x=0) == A(x=0.0)) ``` This will still not work with the number type 3. index lookup on float with int should work closes #6526 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l notation when used in indexes. (Issue #6526, PR #6772)
Description
create the float type which is like a float in python. Update documentation to mention number will be deprecated
add testcases for following scenario and fix it
This will still not work with the number type
closes #6526
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box